Code review comment for lp:~azzar1/software-properties/add-canonical-livepatch

> - layout looks weird here (https://imgur.com/a/qWpRD)

Well spotted Didier. This is the UI equivalent of technical debt: the current implementation lags almost five years behind the current design <https://wiki.ubuntu.com/SoftwareUpdates#settings>, and three of the ways it lags have combined to make this look bad:

(a) There are too many tabs, which makes the whole window wider, which makes the Livepatch options look much more “floaty” than they would be otherwise.

(b) “Install updates from:” is still checkboxes, rather than a menu, which makes it odd that the Livepatch checkbox isn’t lined up with those ones.

(c) All the menus are needlessly wide, so it’s not obvious whether/that the block of menus is centered in the tab, which makes the Livepatch controls appear to be the only block that is centered in the tab, which makes it look out of place.

Fixing (a) or (b) probably seems like far too much work, five weeks before release, just to make Livepatch options look less weird. (Though of course that’s not the only reason to fix them.) Fixing (c) might be practical here, since it’s just changing widths and alignments.

Another way to improve the layout temporarily would be to remove the indentation from the “Install updates from:” checkboxes (which, even if they were supposed to still exist, would not be supposed to be indented anyway!), and then left-align the whole Livepatch block. That way all the checkboxes in the tab would line up.

Separately from all of that:

(d) “To use Livepatch you need to sign in” should be indented from the checkbox, not centered independently — that is, the word “To” should line up exactly with “Use” immediately above.

(e) As shown in the wireframes, the “Sign Out” button should always be exactly the same position and width as the “Sign In…” button.

(f) Therefore, the status text block should be fixed width, regardless of whether the text is “To use Livepatch you need to sign in.”, “Signed in as <email address hidden>.”, or “…<email address hidden> isn’t authorised to use Livepatch.”.