Merge lp:~azzar1/indicator-datetime/drop-dep-from-ubuntu-app-launch into lp:indicator-datetime

Proposed by Andrea Azzarone
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 487
Merged at revision: 487
Proposed branch: lp:~azzar1/indicator-datetime/drop-dep-from-ubuntu-app-launch
Merge into: lp:indicator-datetime
Diff against target: 62 lines (+2/-14)
3 files modified
CMakeLists.txt (+1/-2)
debian/control (+0/-1)
src/notifications.cpp (+1/-11)
To merge this branch: bzr merge lp:~azzar1/indicator-datetime/drop-dep-from-ubuntu-app-launch
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
unity-api-1-bot continuous-integration Needs Fixing
Review via email: mp+328579@code.launchpad.net

Commit message

Drop the dependency from ubuntu-app-launch.

To post a comment you must log in.
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Ack

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2017-02-27 14:29:11 +0000
+++ CMakeLists.txt 2017-08-04 14:09:28 +0000
@@ -52,8 +52,7 @@
52 properties-cpp>=0.0.152 properties-cpp>=0.0.1
53 libaccounts-glib>=1.1853 libaccounts-glib>=1.18
54 messaging-menu>=12.1054 messaging-menu>=12.10
55 uuid>=2.2555 uuid>=2.25)
56 ubuntu-app-launch-3)
57include_directories (SYSTEM ${SERVICE_DEPS_INCLUDE_DIRS})56include_directories (SYSTEM ${SERVICE_DEPS_INCLUDE_DIRS})
5857
59##58##
6059
=== modified file 'debian/control'
--- debian/control 2017-06-05 23:25:57 +0000
+++ debian/control 2017-08-04 14:09:28 +0000
@@ -38,7 +38,6 @@
38# messaging menu integration38# messaging menu integration
39 libmessaging-menu-dev,39 libmessaging-menu-dev,
40 uuid-dev,40 uuid-dev,
41 libubuntu-app-launch3-dev (>= 0.9),
42# to locate the place to put systemd files41# to locate the place to put systemd files
43 systemd,42 systemd,
44Standards-Version: 3.9.343Standards-Version: 3.9.3
4544
=== modified file 'src/notifications.cpp'
--- src/notifications.cpp 2017-02-27 14:29:11 +0000
+++ src/notifications.cpp 2017-08-04 14:09:28 +0000
@@ -24,9 +24,6 @@
24#include <messaging-menu/messaging-menu-app.h>24#include <messaging-menu/messaging-menu-app.h>
25#include <messaging-menu/messaging-menu-message.h>25#include <messaging-menu/messaging-menu-message.h>
2626
27#include <libubuntu-app-launch-3/ubuntu-app-launch/appid.h>
28#include <libubuntu-app-launch-3/ubuntu-app-launch/registry.h>
29
30#include <uuid/uuid.h>27#include <uuid/uuid.h>
3128
32#include <gio/gdesktopappinfo.h>29#include <gio/gdesktopappinfo.h>
@@ -37,7 +34,6 @@
37#include <vector>34#include <vector>
38#include <memory>35#include <memory>
3936
40
41namespace unity {37namespace unity {
42namespace indicator {38namespace indicator {
43namespace notifications {39namespace notifications {
@@ -461,13 +457,7 @@
461457
462 static std::string calendar_app_id()458 static std::string calendar_app_id()
463 {459 {
464 auto registry = std::make_shared<ubuntu::app_launch::Registry>();460 return "org.gnome.Calendar.desktop";
465 auto app_id = ubuntu::app_launch::AppID::discover(registry, "ubuntu-calendar-app");
466 if (!app_id.empty())
467 // Due the use of old API by messaging_menu we need append a extra ".desktop" to the app_id.
468 return std::string(app_id) + ".desktop";
469 else
470 return std::string();
471 }461 }
472462
473 static std::string calendar_app_icon()463 static std::string calendar_app_icon()

Subscribers

People subscribed via source and target branches