Code review comment for lp:~aym-frikha/maas/add-apikey-name-api

Revision history for this message
Mike Pontillo (mpontillo) wrote :

I just finished testing this branch and I think it's looking great. Here's a transcript.

http://paste.ubuntu.com/23289946/

There is one more thing I would change before I think it's okay to land this: we should swap the order of the output in "maas apikey --username admin --with-names". For example, right now I see:

MAAS consumer 9bU8Xw8GqvAEyrfjse:xXSyGnWYAZFWhEjPUq:G4fv6WnQ2KtH73c5gZ4byBqmAc3Dmzwg
Oh, I just remembered. kT85sFzqcNTckx6hNY:TUaQBgL4NK5enVkQec:czDGFca2kNV8EGrugjVSBAjcDc5zkLtQ

It would be easier for someone writing a script to parse this if we place the name *after* the key, since then you always know that everything after the first space is the key name (since key names can contain spaces).

So I would rather the output look like this:

9bU8Xw8GqvAEyrfjse:xXSyGnWYAZFWhEjPUq:G4fv6WnQ2KtH73c5gZ4byBqmAc3Dmzwg MAAS consumer
kT85sFzqcNTckx6hNY:TUaQBgL4NK5enVkQec:czDGFca2kNV8EGrugjVSBAjcDc5zkLtQ Oh, I just remembered.

It also looks better this way since the keys line up.

Thank you for your hard work and dedication on this.

review: Approve

« Back to merge proposal