Merge ~aym-frikha/charm-helpers:Ansible-bug-1748433 into charm-helpers:master

[Aymen Frikha]

[Kevin W Monroe (kwmonroe)]

Per the following thread, charm-helpers source has moved to github:

https://lists.ubuntu.com/archives/juju/2017-September/009496.html

While the source is mirrored here on launchpad, pull requests should be made against the upstream repo here:

https://github.com/juju/charm-helpers

With that said, I'm not seeing the difference between "$HOME/.ansible/tmp" and "~/.ansible/tmp". If forcing this to "/root/..." is indeed necessary, please help me understand why in an issue/PR at the above repository.

Thanks!

review: Disapprove

[Aymen Frikha (aym-frikha)]

Kevin, please take a look at : https://github.com/juju/charm-helpers/pull/181

Unmerged commits

fb281c1... by Aymen Frikha on 2018-05-13

LP:#1748433
Ansible version changed from 2.0 to 2.5 and there is several changes in newer version.
The default config of remote_tmp changed from " $HOME/.ansible/tmp" to "~/.ansible/tmp".
We need to handle variable "ansible_remote_tmp" variable explicitly to avoid any problem
in newer versions.

diff --git a/charmhelpers/contrib/ansible/__init__.py b/charmhelpers/contrib/ansible/__init__.py
index f3617db..5281946 100644
--- a/charmhelpers/contrib/ansible/__init__.py
+++ b/charmhelpers/contrib/ansible/__init__.py
@@ -134,7 +134,7 @@ def install_ansible_support(from_ppa=True, ppa_location='ppa:rquillo/ansible'):
         charmhelpers.fetch.apt_update(fatal=True)
     charmhelpers.fetch.apt_install('ansible')
     with open(ansible_hosts_path, 'w+') as hosts_file:
-        hosts_file.write('localhost ansible_connection=local')
+        hosts_file.write('localhost ansible_connection=local ansible_remote_tmp=/root/.ansible/tmp')
 
 
 def apply_playbook(playbook, tags=None, extra_vars=None):