Code review comment for lp:~axwalk/juju-core/wire-up-prechecker-take2

On 2014/02/14 09:39:44, axw wrote:
> It doesn't seem ideal to allow containers for everyone, letting users
shoot
> themselves, to enable ELB, proxies, whatever. It'd be nice to have
something
> inside the charm that indicates what it requires (or doesn't require?)
so that
> we know to let those special cases through. OTOH, are users likely to
> "add-machine lxc" if they don't know what they're doing?

Yeah, I think a charm flag (i-dont-need-an-address? ;p) is probably the
best approach. Once we have one of those we can do it all internally,
and expose a cmdline flag for add-machine, for those users who really do
know what they're doing.

> In any case, there's work to be done. I can change it to allow
containers to
> begin with.

Ideal, thanks.

> > There's definitely value in prechecking environ instances though.

https://codereview.appspot.com/61520045/