Code review comment for lp:~axwalk/juju-core/testing-mgo-wait-listening

Revision history for this message
Andrew Wilkins (axwalk) wrote :

Reviewers: mp+218571_code.launchpad.net,

Message:
Please take a look.

Description:
Improve mgo testing

- Use testing.MgoSuite in the store package
- Wait for "waiting for connections" message in mongod
   output before starting tests.
- Fix testing.MgoInstance.DialInfo to configure
   the client based on whether TLS is being used.

https://code.launchpad.net/~axwalk/juju-core/testing-mgo-wait-listening/+merge/218571

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/97110043/

Affected files (+90, -140 lines):
   A [revision details]
   D store/mgo_test.go
   M store/store_test.go
   M testing/mgo.go

« Back to merge proposal