Code review comment for lp:~axwalk/juju-core/testing-mgo-nounixsocket

Revision history for this message
Andrew Wilkins (axwalk) wrote :

Reviewers: mp+181218_code.launchpad.net,

Message:
Please take a look.

Description:
testing: pass --nounixsocket to mongod

The tests are leaving Unix socket files
in $TMPDIR when mongod is killed. We
don't need Unix sockets for mongod in
our tests, so just disable them.

https://code.launchpad.net/~axwalk/juju-core/testing-mgo-nounixsocket/+merge/181218

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/12828046/

Affected files:
   A [revision details]
   M testing/mgo.go

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: tarmac-20130821051648-ovunbhgihpcax89h
+New revision: <email address hidden>

Index: testing/mgo.go
=== modified file 'testing/mgo.go'
--- testing/mgo.go 2013-07-31 08:17:33 +0000
+++ testing/mgo.go 2013-08-21 08:25:04 +0000
@@ -78,6 +78,7 @@
    "--noprealloc",
    "--smallfiles",
    "--nojournal",
+ "--nounixsocket",
   }
   server := exec.Command("mongod", mgoargs...)
   out, err := server.StdoutPipe()

« Back to merge proposal