Code review comment for lp:~axwalk/juju-core/state-dialtimeout

I'm pretty sure that most of our test suite code uses fastDialOpts =
DialOptions{}, don't they? It is possible that we have a test that is
waiting the 10 min to connect, which is why we get occasional 'timeout
exceeded' bugs, but I would actually guess that is a different deadlock.

Anyway, I'm happy enough reducing this, since we shouldn't ever be trying
to connect to Mongo directly before the machine is up, which is the only
reason we were waiting 10 minutes before.

LGTM

On Wed, May 7, 2014 at 12:25 PM, Andrew Wilkins <
<email address hidden>> wrote:

> The proposal to merge lp:~axwalk/juju-core/state-dialtimeout into
> lp:juju-core has been updated.
>
> Description changed to:
>
> state: reduce default dial timeout to 30s
>
> Previously we could have been dialling state connections
> across the Internet, since the CLI would connect to Mongo
> directly. Now, with the CLI going to API only, we can
> safely reduce the timeout.
>
> It is possible that the timeout will be exceeded if the
> peers in an HA setup are not all ready. In this case the
> dial operation will fail and the caller (state server agent)
> will restart.
>
> This change will reduce the time to failure in tests, and
> allow us to capture some information about the failed test
> without exceeding the Go test timeout.
>
> https://codereview.appspot.com/97100045/
>
>
> For more details, see:
>
> https://code.launchpad.net/~axwalk/juju-core/state-dialtimeout/+merge/218568
> --
>
> https://code.launchpad.net/~axwalk/juju-core/state-dialtimeout/+merge/218568
> You are subscribed to branch lp:juju-core.
>