juju-core

Code review comment for lp:~axwalk/juju-core/sshstorage-tmpdir

Revision history for this message

Tim Penhey (thumper) wrote on 2013-09-20:

for tests that are whitebox tests, we have had an informal convention of
naming them _whitebox_test.go instead of _test.go

LGTM

https://codereview.appspot.com/13660047/diff/7001/environs/sshstorage/storage_test.go#newcode4
environs/sshstorage/storage_test.go:4: package sshstorage
On 2013/09/19 02:36:19, axw1 wrote:
> On 2013/09/18 21:30:56, thumper wrote:
> > Normally the tests would be in sshstorage_test package.
> >
> > Is there any reason why this is a whitebox test?

> Yes, so the tests can mock out "sshCommand". See the call to jc.Set in
> SetUpSuite.

jc.Set has moved, and is about to move again with my branch :-)

testing.PatchValue
until it becomes
testbase.PatchValue