for tests that are whitebox tests, we have had an informal convention of naming them _whitebox_test.go instead of _test.go
LGTM
https://codereview.appspot.com/13660047/diff/7001/environs/sshstorage/storage_test.go File environs/sshstorage/storage_test.go (right):
https://codereview.appspot.com/13660047/diff/7001/environs/sshstorage/storage_test.go#newcode4 environs/sshstorage/storage_test.go:4: package sshstorage On 2013/09/19 02:36:19, axw1 wrote: > On 2013/09/18 21:30:56, thumper wrote: > > Normally the tests would be in sshstorage_test package. > > > > Is there any reason why this is a whitebox test?
> Yes, so the tests can mock out "sshCommand". See the call to jc.Set in > SetUpSuite.
jc.Set has moved, and is about to move again with my branch :-)
testing.PatchValue until it becomes testbase.PatchValue
https://codereview.appspot.com/13660047/
« Back to merge proposal
for tests that are whitebox tests, we have had an informal convention of
naming them _whitebox_test.go instead of _test.go
LGTM
https:/ /codereview. appspot. com/13660047/ diff/7001/ environs/ sshstorage/ storage_ test.go sshstorage/ storage_ test.go (right):
File environs/
https:/ /codereview. appspot. com/13660047/ diff/7001/ environs/ sshstorage/ storage_ test.go# newcode4 sshstorage/ storage_ test.go: 4: package sshstorage
environs/
On 2013/09/19 02:36:19, axw1 wrote:
> On 2013/09/18 21:30:56, thumper wrote:
> > Normally the tests would be in sshstorage_test package.
> >
> > Is there any reason why this is a whitebox test?
> Yes, so the tests can mock out "sshCommand". See the call to jc.Set in
> SetUpSuite.
jc.Set has moved, and is about to move again with my branch :-)
testing. PatchValue PatchValue
until it becomes
testbase.
https:/ /codereview. appspot. com/13660047/