Code review comment for lp:~axwalk/juju-core/sshstorage-tmpdir

https://codereview.appspot.com/13660047/diff/7001/environs/sshstorage/storage_test.go
File environs/sshstorage/storage_test.go (right):

https://codereview.appspot.com/13660047/diff/7001/environs/sshstorage/storage_test.go#newcode4
environs/sshstorage/storage_test.go:4: package sshstorage
Normally the tests would be in sshstorage_test package.

Is there any reason why this is a whitebox test?

https://codereview.appspot.com/13660047/diff/7001/environs/sshstorage/storage_test.go#newcode74
environs/sshstorage/storage_test.go:74: func (s *storageSuite)
makeStorage(c *gc.C) (storage *SSHStorage, storageDir string) {
Why name the return parameters here? You aren't really gaining much. Is
it just to provide more assistance to the reader?

https://codereview.appspot.com/13660047/