Please take a look.
https://codereview.appspot.com/58490043/diff/1/state/apiserver/client/client_test.go File state/apiserver/client/client_test.go (right):
https://codereview.appspot.com/58490043/diff/1/state/apiserver/client/client_test.go#newcode1718 state/apiserver/client/client_test.go:1718: c.Assert(script, gc.Not(jc.Contains), "apt-get") On 2014/01/30 03:07:10, wallyworld wrote: > Please add the opposite check to the test above this one to ensure apt-get still > gets inserted in the script when DisablePackageCommands is false
Done. I'd rather test the option separately, so I just modified this test to range over []bool{false, true} and alter the checker accordingly.
https://codereview.appspot.com/58490043/
« Back to merge proposal
Please take a look.
https:/ /codereview. appspot. com/58490043/ diff/1/ state/apiserver /client/ client_ test.go /client/ client_ test.go (right):
File state/apiserver
https:/ /codereview. appspot. com/58490043/ diff/1/ state/apiserver /client/ client_ test.go# newcode1718 /client/ client_ test.go: 1718: c.Assert(script, jc.Contains) , "apt-get") ommands is false
state/apiserver
gc.Not(
On 2014/01/30 03:07:10, wallyworld wrote:
> Please add the opposite check to the test above this one to ensure
apt-get still
> gets inserted in the script when DisablePackageC
Done. I'd rather test the option separately, so I just modified this
test to range over []bool{false, true} and alter the checker
accordingly.
https:/ /codereview. appspot. com/58490043/