Code review comment for lp:~axwalk/juju-core/provisioningscript-api-disableaptcommands

Revision history for this message
Ian Booth (wallyworld) wrote :

LGTM with a test tweak

https://codereview.appspot.com/58490043/diff/1/state/apiserver/client/client_test.go
File state/apiserver/client/client_test.go (right):

https://codereview.appspot.com/58490043/diff/1/state/apiserver/client/client_test.go#newcode1718
state/apiserver/client/client_test.go:1718: c.Assert(script,
gc.Not(jc.Contains), "apt-get")
Please add the opposite check to the test above this one to ensure
apt-get still gets inserted in the script when DisablePackageCommands is
false

https://codereview.appspot.com/58490043/

« Back to merge proposal