Code review comment for lp:~axwalk/juju-core/manual-bootstrap
Revision history for this message
| Andrew Wilkins (axwalk) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Haven't pushed changes yet, need to sort out the storage issues. Here's
my answers anyway.
https:/
File cmd/jujud/
https:/
cmd/jujud/
"launchpad.
On 2013/09/13 09:24:59, fwereade wrote:
> drop the explicit name?
Done.
https:/
File environs/
https:/
environs/
(environs.Storage, error) {
On 2013/09/13 09:24:59, fwereade wrote:
> High-level question while I think of it: does the SSHStorage on
bootstrap get
> reused but backed with a FileStorage? I sort of imagine so, in which
case, cool
> ...but is it possible for there to be overlap? ie should we be sharing
the
> flocking everywhere?
> or am I just fantasizing?
filestorage is only used for testing at the moment.
environs/
storage directory. However, there is no overlap in use;
environs/sshstorage is only used to write the tools and bootstrap state
file. *If* there's a failure bootstrapping, the bootstrap storage may
also be used to remove the state file.
Since there's no overlap, there's no need to share the locking. I did
just realise that I totally broke the manual bootstrap code though, when
I changed sshstorage's directory structure. I'll have to revisit that
before merging.
https:/
environs/
ioutil.TempFile("", "juju-filestora
On 2013/09/13 09:24:59, fwereade wrote:
> Same different-
This is only for testing, but I will fix it anyway. I think localstorage
ought to be renamed httpstorage, and have the backend contain one of
these.
https:/
File environs/
https:/
environs/
On 2013/09/13 09:24:59, fwereade wrote:
> OK, I think my problem here is maybe that it's not *just* about
bootstrap
> storage, right? It's the same storage we always use, but this is the
path to it
> that's accessible from a client machine. Yes?
> So, at least in the short term, we *will* need SSHStorage and
LocalStorage to
> coexist.
They're pointing to the same location, but they're never used
concurrently.
https:/
File worker/
https:/
worker/
On 2013/09/13 09:24:59, fwereade wrote:
> ah, I see. Can we call this localstorage please?
Sorry, fixed.
https:/