Code review comment for lp:~axwalk/juju-core/lp1315216-lxc-use-clone

On 2014/05/08 10:43:00, wallyworld wrote:
> Thanks very much for picking this up. We need tests for the new api
calls and
> also possibly the new code in container_initialisation. So long as
it's been
> tested with lxc-use-clone set to true and false, LGTM

Added unit tests. I have run it live, doing it once more before landing.

https://codereview.appspot.com/96140044/diff/1/state/api/provisioner/provisioner.go
> File state/api/provisioner/provisioner.go (right):

https://codereview.appspot.com/96140044/diff/1/state/api/provisioner/provisioner.go#newcode118
> state/api/provisioner/provisioner.go:118: func (st *State)
> ContainerManagerConfig(args params.ContainerManagerConfigParams)
(result
> params.ContainerManagerConfig, err error) {
> Need a doc comment

https://codereview.appspot.com/96140044/diff/1/state/apiserver/provisioner/provisioner.go
> File state/apiserver/provisioner/provisioner.go (right):

https://codereview.appspot.com/96140044/diff/1/state/apiserver/provisioner/provisioner.go#newcode194
> state/apiserver/provisioner/provisioner.go:194: //
ContainerManagerConfig
> returns information from the environment config that are
> that is needed

https://codereview.appspot.com/96140044/