Code review comment for lp:~axwalk/juju-core/lp1292275-localdestroy-stopremovemongod

Revision history for this message
Andrew Wilkins (axwalk) wrote :

On 2014/03/24 10:15:26, fwereade wrote:
> Can we think of any way to test this? Does it come down to CI tests
that
> carefully break a local environment in a number of ways, and check it
can still
> be torn down?

I can't think of a decent way to unit test it. It's not too hard for an
integration test:

Copy juju binary somewhere, and write a script called jujud in the same
dir.
The jujud script will be called with "version", and then later with
"bootstrap-state". It must respond to "version" with a valid version; if
it errors on bootstrap-state, it'll trigger the
destroy-on-failed-bootstrap codepath and the mongo service will be
removed (with this patch).

https://codereview.appspot.com/78770043/

« Back to merge proposal