On 2014/03/21 15:03:23, dimitern wrote: > This is great, LGTM, assuming you tested it live.
Thanks, yes I have tested with local, manual and openstack. I realised I could remove LoadStateFromURL altogether, so I went ahead and did that.
> https://codereview.appspot.com/78840044/diff/1/cmd/jujud/bootstrap.go > File cmd/jujud/bootstrap.go (right):
https://codereview.appspot.com/78840044/diff/1/cmd/jujud/bootstrap.go#newcode65 > cmd/jujud/bootstrap.go:65: if err = c.Conf.read("machine-0"); err != nil { > s/=/:=/
https://codereview.appspot.com/78840044/
« Back to merge proposal
On 2014/03/21 15:03:23, dimitern wrote:
> This is great, LGTM, assuming you tested it live.
Thanks, yes I have tested with local, manual and openstack.
I realised I could remove LoadStateFromURL altogether, so I went ahead
and did that.
> https:/ /codereview. appspot. com/78840044/ diff/1/ cmd/jujud/ bootstrap. go bootstrap. go (right):
> File cmd/jujud/
https:/ /codereview. appspot. com/78840044/ diff/1/ cmd/jujud/ bootstrap. go#newcode65 bootstrap. go:65: if err = c.Conf. read("machine- 0"); err !=
> cmd/jujud/
nil {
> s/=/:=/
https:/ /codereview. appspot. com/78840044/