Code review comment for lp:~axwalk/juju-core/lp1291292-jujud-bootstrap-nostateurl

Reviewers: mp+212172_code.launchpad.net,

Message:
Please take a look.

Description:
Pass instance-id/hardware directly to jujud

The bootstrap-state agent currently loads its
instance ID and hardware characteristics by
fetching a URL that is written to a file on
disk. This is no longer necessary with
synchronous bootstrap.

I have changed jujud and bootstrap script
generation to pass the instance-id and hardware
characteristics directly to jujud as command
line arguments.

Fixes part of lp:1291292

https://code.launchpad.net/~axwalk/juju-core/lp1291292-jujud-bootstrap-nostateurl/+merge/212172

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/78840044/

Affected files (+140, -141 lines):
   A [revision details]
   M cloudinit/sshinit/configure_test.go
   M cmd/jujud/bootstrap.go
   M cmd/jujud/bootstrap_test.go
   M cmd/jujud/main_test.go
   M environs/cloudinit.go
   M environs/cloudinit/cloudinit.go
   M environs/cloudinit/cloudinit_test.go
   M environs/manual/bootstrap.go
   M instance/instance.go
   M provider/common/bootstrap.go
   M provider/common/bootstrap_test.go
   M provider/local/environ.go