juju-core

Code review comment for lp:~axwalk/juju-core/lp1274780-osuser-fallback

  1. lp1274780-osuser-fallback
  2. Merge into trunk
Revision history for this message
Tim Penhey (thumper) wrote :

On 2014/02/14 01:03:27, axw wrote:

https://codereview.appspot.com/58970043/diff/1/provider/local/environprovider.go
> File provider/local/environprovider.go (right):

https://codereview.appspot.com/58970043/diff/1/provider/local/environprovider.go#newcode60
> provider/local/environprovider.go:60: username = u.Username
> On 2014/02/13 21:58:04, thumper wrote:
> > should we lowercase this?

> Nope, *nix usernames are case sensitive.

LGTM

https://codereview.appspot.com/58970043/

« Back to merge proposal