Code review comment for lp:~axwalk/juju-core/lp1274780-osuser-fallback

Revision history for this message
Andrew Wilkins (axwalk) wrote :

https://codereview.appspot.com/58970043/diff/1/provider/local/environprovider_test.go
File provider/local/environprovider_test.go (right):

https://codereview.appspot.com/58970043/diff/1/provider/local/environprovider_test.go#newcode262
provider/local/environprovider_test.go:262: userOSErr: errors.New("oh
noes"),
On 2014/01/31 09:25:07, dimitern wrote:
> You could just define userOSErr as string and construct an error from
it in
> PatchValue below.

I was going to initially, but it's more long-winded that way. You need
to check if the string != "", and only then create an error. I'll leave
it unless you strongly object.

https://codereview.appspot.com/58970043/

« Back to merge proposal