Code review comment for lp:~axwalk/juju-core/lp1274780-osuser-fallback

Revision history for this message
Dave Cheney (dave-cheney) wrote :

Why not just always call http://golang.org/pkg/os/user/#Current, that has
the same semantics as you described.

On Fri, Jan 31, 2014 at 8:27 PM, Dimiter Naydenov <
<email address hidden>> wrote:

> LGTM with one comment.
>
>
>
> https://codereview.appspot.com/58970043/diff/1/provider/local/environprovider_test.go
> File provider/local/environprovider_test.go (right):
>
>
> https://codereview.appspot.com/58970043/diff/1/provider/local/environprovider_test.go#newcode262
> provider/local/environprovider_test.go:262: userOSErr: errors.New("oh
> noes"),
> You could just define userOSErr as string and construct an error from it
> in PatchValue below.
>
> https://codereview.appspot.com/58970043/
>
> --
>
> https://code.launchpad.net/~axwalk/juju-core/lp1274780-osuser-fallback/+merge/204173
> You are subscribed to branch lp:juju-core.
>

« Back to merge proposal