Code review comment for lp:~axwalk/juju-core/lp1274780-osuser-fallback

Revision history for this message
Dimiter Naydenov (dimitern) wrote :

LGTM with one comment.

https://codereview.appspot.com/58970043/diff/1/provider/local/environprovider_test.go
File provider/local/environprovider_test.go (right):

https://codereview.appspot.com/58970043/diff/1/provider/local/environprovider_test.go#newcode262
provider/local/environprovider_test.go:262: userOSErr: errors.New("oh
noes"),
You could just define userOSErr as string and construct an error from it
in PatchValue below.

https://codereview.appspot.com/58970043/

« Back to merge proposal