https://codereview.appspot.com/77890045/diff/1/provider/maas/environ.go#newcode316
provider/maas/environ.go:316:
utils.CommandString(utils.AptGetCommand("update")...),
It seems a pity that we can't just call SetAptUpdate on the
cloudinit config, but that would require a change to ComposeUserData
(might it make sense to pass in a possibly-nil cloudinit.Config to that
function?)
Aside: CommandString should also escape backquotes, although it won't be
a problem here
LGTM with a couple of thoughts below.
https:/ /codereview. appspot. com/77890045/ diff/1/ provider/ maas/environ. go maas/environ. go (right):
File provider/
https:/ /codereview. appspot. com/77890045/ diff/1/ provider/ maas/environ. go#newcode316 maas/environ. go:316: ring(utils. AptGetCommand( "update" )...),
provider/
utils.CommandSt
It seems a pity that we can't just call SetAptUpdate on the
cloudinit config, but that would require a change to ComposeUserData
(might it make sense to pass in a possibly-nil cloudinit.Config to that
function?)
Aside: CommandString should also escape backquotes, although it won't be
a problem here
https:/ /codereview. appspot. com/77890045/ diff/1/ provider/ maas/environ_ test.go maas/environ_ test.go (right):
File provider/
https:/ /codereview. appspot. com/77890045/ diff/1/ provider/ maas/environ_ test.go# newcode208 maas/environ_ test.go: 208: const aptGetPrefix = "env FRONTEND= noninteractive apt-get Dpkg::Options: :=--force- confold Dpkg::options: :=--force- unsafe- io --assume-yes --quiet" mand()
provider/
DEBIAN_
--option=
--option=
or aptGetPrefix := utils.AptGetCom
?
https:/ /codereview. appspot. com/77890045/