I'd really like to see this tested live, though I'm not sure it will be
easy to set up the test (you'll have to populate a couple versions of
the tools, and then bootstrap with an old version of them).
We'll also certainly want to let CI know about it right away, since it
will change how they do some of their testing.
I'd really like to see this tested live, though I'm not sure it will be
easy to set up the test (you'll have to populate a couple versions of
the tools, and then bootstrap with an old version of them).
We'll also certainly want to let CI know about it right away, since it
will change how they do some of their testing.
Mostly, though, LGTM.
https:/ /codereview. appspot. com/88840043/ diff/1/ environs/ bootstrap/ bootstrap. go bootstrap/ bootstrap. go (right):
File environs/
https:/ /codereview. appspot. com/88840043/ diff/1/ environs/ bootstrap/ bootstrap. go#newcode72 bootstrap/ bootstrap. go:72: // We should only ever bootstrap the
environs/
exact same version as the client,
This whole chunk of code seems quite localized, is it possible to just
pull it into a helper function to keep the units of work focused?
https:/ /codereview. appspot. com/88840043/