Code review comment for lp:~axwalk/juju-core/lp1247232-bootstrap-majorminorpatch

Revision history for this message
John A Meinel (jameinel) wrote :

I'd really like to see this tested live, though I'm not sure it will be
easy to set up the test (you'll have to populate a couple versions of
the tools, and then bootstrap with an old version of them).

We'll also certainly want to let CI know about it right away, since it
will change how they do some of their testing.

Mostly, though, LGTM.

https://codereview.appspot.com/88840043/diff/1/environs/bootstrap/bootstrap.go
File environs/bootstrap/bootstrap.go (right):

https://codereview.appspot.com/88840043/diff/1/environs/bootstrap/bootstrap.go#newcode72
environs/bootstrap/bootstrap.go:72: // We should only ever bootstrap the
exact same version as the client,
This whole chunk of code seems quite localized, is it possible to just
pull it into a helper function to keep the units of work focused?

https://codereview.appspot.com/88840043/

« Back to merge proposal