This code is nice and straightforward, but because I was digging around
with the other test changes, I noticed that the tests of the API don't
actually exercise the Retry logic.
I'm not going to block landing this on writing those tests, because you
aren't *reducing* test coverage at all. But could you try to add some
coverage while we're away from it?
If the test is too fiddly or time consuming, file a tech-debt bug, link
to it in the source code and you can land this.
This code is nice and straightforward, but because I was digging around
with the other test changes, I noticed that the tests of the API don't
actually exercise the Retry logic.
I'm not going to block landing this on writing those tests, because you
aren't *reducing* test coverage at all. But could you try to add some
coverage while we're away from it?
If the test is too fiddly or time consuming, file a tech-debt bug, link
to it in the source code and you can land this.
https:/ /codereview. appspot. com/20670044/