Code review comment for lp:~axwalk/juju-core/lp1237709-bootstrap-placement

Revision history for this message
Andrew Wilkins (axwalk) wrote :

Reviewers: mp+216971_code.launchpad.net,

Message:
Please take a look.

Description:
Support placement directives on bootstrap

juju bootstrap will accept a single, optional
positional argument that will be parsed as a
placement directive. We currently only allow
unscoped placement directives at bootstrap.

https://code.launchpad.net/~axwalk/juju-core/lp1237709-bootstrap-placement/+merge/216971

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/91740043/

Affected files (+156, -108 lines):
   A [revision details]
   M cmd/juju/bootstrap.go
   M cmd/juju/bootstrap_test.go
   M cmd/juju/cmd_test.go
   M cmd/juju/deploy_test.go
   M cmd/plugins/juju-restore/restore.go
   M environs/bootstrap/bootstrap.go
   M environs/bootstrap/bootstrap_test.go
   M environs/interface.go
   M environs/jujutest/livetests.go
   M environs/jujutest/tests.go
   M environs/open_test.go
   M juju/apiconn_test.go
   M juju/conn_test.go
   M juju/testing/conn.go
   M provider/azure/environ.go
   M provider/common/bootstrap.go
   M provider/common/bootstrap_test.go
   M provider/common/mock_test.go
   M provider/dummy/environs.go
   M provider/ec2/ec2.go
   M provider/ec2/local_test.go
   M provider/joyent/environ.go
   M provider/joyent/local_test.go
   M provider/local/config_test.go
   M provider/local/environ.go
   M provider/local/environ_test.go
   M provider/maas/environ.go
   M provider/maas/environ_whitebox_test.go
   M provider/manual/environ.go
   M provider/openstack/live_test.go
   M provider/openstack/local_test.go
   M provider/openstack/provider.go

« Back to merge proposal