Code review comment for lp:~axwalk/juju-core/lp1235716-sshstorage-sudo-prompt

On 2013/10/09 17:55:40, fwereade wrote:
> On 2013/10/08 10:14:00, axw wrote:
> > On 2013/10/08 07:48:25, fwereade wrote:
> > > We should not be using these. Sorry, I must have missed it before;
but if
> > you're
> > > running in a command you should have a cmd.Context available and
should be
> > using
> > > in/out/err from that.
> >
> > How do you get that into an Environ? Because that's where
NewSSHStorage is
> > called.

> Ha. Sorry, I did not think that through. OK, consider this LGTM with a
tech-debt
> bug -- it's not worth blocking something so user-helpful over
architectural
> quibbling. Sinzui said he wouldn't be cutting a release until
tomorrow, so you
> have my blessing to squeeze this into 1.16 if you can.

> If you have any bright ideas that might help answer your question,
though, I'm
> all ears.

Thanks, I'll log a bug for now, and have a think about it.

https://codereview.appspot.com/14461044/