Code review comment for lp:~axwalk/juju-core/lp1235716-sshstorage-sudo-prompt

https://codereview.appspot.com/14461044/diff/1/environs/sshstorage/storage.go
File environs/sshstorage/storage.go (right):

https://codereview.appspot.com/14461044/diff/1/environs/sshstorage/storage.go#newcode87
environs/sshstorage/storage.go:87: cmd.Stdout = os.Stdout // for sudo
prompts/output
We should not be using these. Sorry, I must have missed it before; but
if you're running in a command you should have a cmd.Context available
and should be using in/out/err from that.

This should in general make it an awful lot easier to test, too.

https://codereview.appspot.com/14461044/