Fine with the idea, I think the implementation's in the wrong place.
https://codereview.appspot.com/14218044/diff/6001/environs/simplestreams/simplestreams.go File environs/simplestreams/simplestreams.go (right):
https://codereview.appspot.com/14218044/diff/6001/environs/simplestreams/simplestreams.go#newcode406 environs/simplestreams/simplestreams.go:406: if err == nil && len(items) != 0 { I'm not sure this is the right place for it -- it's a hack-on-a-hack, instead of removing the original hack in getmaybeSignedMetadata that replaces errors with nil.
https://codereview.appspot.com/14218044/
« Back to merge proposal
Fine with the idea, I think the implementation's in the wrong place.
https:/ /codereview. appspot. com/14218044/ diff/6001/ environs/ simplestreams/ simplestreams. go simplestreams/ simplestreams. go (right):
File environs/
https:/ /codereview. appspot. com/14218044/ diff/6001/ environs/ simplestreams/ simplestreams. go#newcode406 simplestreams/ simplestreams. go:406: if err == nil && len(items) etadata that
environs/
!= 0 {
I'm not sure this is the right place for it -- it's a hack-on-a-hack,
instead of removing the original hack in getmaybeSignedM
replaces errors with nil.
https:/ /codereview. appspot. com/14218044/