Code review comment for lp:~axwalk/juju-core/lp1218329-azure-released-images

Revision history for this message
Dave Cheney (dave-cheney) wrote :

https://docs.google.com/a/canonical.com/document/d/1M_ZTAtVfz55U_jvzXaMEIZ2-yqPqjAeIIiQxEW7mfe0/edit

On Mon, Sep 2, 2013 at 4:09 PM, Andrew Wilkins
<email address hidden> wrote:
> On 2013/09/02 05:41:58, jameinel wrote:
>> LGTM.
>
>> I think we actually need to target whatever branch Dave Cheney brings
> out for
>> the 1.14 series, but we can land this in trunk and then land it in
> 1.14 when we
>> are able to.
>
>
> https://codereview.appspot.com/13464043/diff/1/provider/azure/config.go
>> File provider/azure/config.go (right):
>
>
> https://codereview.appspot.com/13464043/diff/1/provider/azure/config.go#newcode151
>> provider/azure/config.go:151: default-series: precise
>> Because the global DefaultSeries is precise, I would put this in a
> comment.
>
> Done.
>
> https://codereview.appspot.com/13464043/
>
> --
> https://code.launchpad.net/~axwalk/juju-core/lp1218329-azure-released-images/+merge/183381
> You are subscribed to branch lp:juju-core.

« Back to merge proposal