Code review comment for lp:~axwalk/juju-core/lp1210328-update-ppa

Revision history for this message
Andrew Wilkins (axwalk) wrote :

Reviewers: mp+179340_code.launchpad.net,

Message:
Please take a look.

Description:
Update juju ppa in cloudinit to juju/stable

James Page has updated the juju/stable PPA to
include mongodb for Precise and Quantal. We
need to update our code and docs accordingly.

Fixes bug #1210328

https://code.launchpad.net/~axwalk/juju-core/lp1210328-update-ppa/+merge/179340

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/12583044/

Affected files:
   A [revision details]
   M environs/cloudinit/cloudinit.go
   M environs/cloudinit/cloudinit_test.go

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: tarmac-20130809021225-6c5p05y8zs5j83o3
+New revision: <email address hidden>

Index: environs/cloudinit/cloudinit.go
=== modified file 'environs/cloudinit/cloudinit.go'
--- environs/cloudinit/cloudinit.go 2013-08-02 15:50:58 +0000
+++ environs/cloudinit/cloudinit.go 2013-08-09 06:56:44 +0000
@@ -171,7 +171,7 @@

   if cfg.StateServer {
    if cfg.NeedMongoPPA() {
- c.AddAptSource("ppa:juju/experimental", "1024R/C8068B11")
+ c.AddAptSource("ppa:juju/stable", "1024R/C8068B11")
    }
    c.AddPackage("mongodb-server")
    certKey := string(cfg.StateServerCert) + string(cfg.StateServerKey)

Index: environs/cloudinit/cloudinit_test.go
=== modified file 'environs/cloudinit/cloudinit_test.go'
--- environs/cloudinit/cloudinit_test.go 2013-08-02 15:50:58 +0000
+++ environs/cloudinit/cloudinit_test.go 2013-08-09 06:56:44 +0000
@@ -322,7 +322,7 @@
    if test.cfg.StateServer {
     checkPackage(c, x, "mongodb-server", true)
     source := struct{ source, key string }{
- source: "ppa:juju/experimental",
+ source: "ppa:juju/stable",
      key: "1024R/C8068B11",
     }
     checkAptSource(c, x, source, test.cfg.NeedMongoPPA())

« Back to merge proposal