On 2013/07/23 05:13:38, axw1 wrote:
> On 2013/07/23 04:46:22, dfc wrote:
> > On 2013/07/23 04:39:06, axw wrote:
> > > Please take a look.
> >
> > Is there a test that covers this ?
> There is not. How would you test it without duplicating the numbers?
Nor is it likely to matter much: IIRC this change doesn't raise the
prices above any others in the same respective regions, in which case I
don't think it'll affect instance-type selection. But definitely good
to be rid of this little particle of weirdness before it starts serving
as a bad example. LGTM, with thanks.
On 2013/07/23 05:13:38, axw1 wrote:
> On 2013/07/23 04:46:22, dfc wrote:
> > On 2013/07/23 04:39:06, axw wrote:
> > > Please take a look.
> >
> > Is there a test that covers this ?
> There is not. How would you test it without duplicating the numbers?
Nor is it likely to matter much: IIRC this change doesn't raise the
prices above any others in the same respective regions, in which case I
don't think it'll affect instance-type selection. But definitely good
to be rid of this little particle of weirdness before it starts serving
as a bad example. LGTM, with thanks.
https:/ /codereview. appspot. com/11419046/