Code review comment for lp:~axwalk/juju-core/lp1186969-add-jujud-tools-help

Revision history for this message
Andrew Wilkins (axwalk) wrote :

> I'm suggesting that we only fill the slice with non-nil elements
> (hence my suggestion to use append rather than "cmds[i] = c")
> which would mean that even if NewCommand fails, we won't
> need to test for a nil element in the second loop.

Done, PTAL.

« Back to merge proposal