Code review comment for lp:~axwalk/juju-core/lp1121916-juju-status-filters

Revision history for this message
Andrew Wilkins (axwalk) wrote :

Reviewers: mp+178004_code.launchpad.net,

Message:
Please take a look.

Description:
juju status: add service/unit filters

Any positional arguments after juju status are
now interpreted as filters for either service or
unit. If the filter includes a '/', then it is
considered a unit filter, else a service filter.

If all units of a service are filtered out, then
the service is filtered out; if all units of a
machine are filtered out, the machine is filtered
out (except to fill out the container hierarchy).

Filters are implemented using using shell file
name pattern matching, like in pyjuju. See:
     http://golang.org/pkg/path/#Match

Partially fixes bug 1121916

https://code.launchpad.net/~axwalk/juju-core/lp1121916-juju-status-filters/+merge/178004

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/12235043/

Affected files:
   [revision details]
   cmd/juju/cmd_test.go
   cmd/juju/status.go
   cmd/juju/status_test.go

« Back to merge proposal