Code review comment for lp:~axwalk/juju-core/localstorage-to-httpstorage

The attempt to merge lp:~axwalk/juju-core/localstorage-to-httpstorage into lp:juju-core failed. Below is the output from the failed tests.

ok launchpad.net/juju-core/agent 0.940s
ok launchpad.net/juju-core/agent/tools 0.304s
ok launchpad.net/juju-core/bzr 7.841s
ok launchpad.net/juju-core/cert 2.141s
ok launchpad.net/juju-core/charm 0.601s
? launchpad.net/juju-core/charm/hooks [no test files]
ok launchpad.net/juju-core/cloudinit 0.022s
ok launchpad.net/juju-core/cmd 0.207s
? launchpad.net/juju-core/cmd/builddb [no test files]
? launchpad.net/juju-core/cmd/charmd [no test files]
? launchpad.net/juju-core/cmd/charmload [no test files]
ok launchpad.net/juju-core/cmd/juju 138.797s
ok launchpad.net/juju-core/cmd/jujud 40.019s
ok launchpad.net/juju-core/cmd/plugins/juju-metadata 1.869s
ok launchpad.net/juju-core/constraints 0.024s
ok launchpad.net/juju-core/container/lxc 0.394s
? launchpad.net/juju-core/container/lxc/mock [no test files]
ok launchpad.net/juju-core/downloader 5.282s
ok launchpad.net/juju-core/environs 1.976s
ok launchpad.net/juju-core/environs/bootstrap 5.172s
ok launchpad.net/juju-core/environs/cloudinit 0.451s
ok launchpad.net/juju-core/environs/config 0.796s
ok launchpad.net/juju-core/environs/configstore 0.066s
ok launchpad.net/juju-core/environs/filestorage 0.061s
ok launchpad.net/juju-core/environs/httpstorage 0.245s
ok launchpad.net/juju-core/environs/imagemetadata 0.535s
ok launchpad.net/juju-core/environs/instances 0.256s
ok launchpad.net/juju-core/environs/jujutest 0.226s
ok launchpad.net/juju-core/environs/manual 1.173s
ok launchpad.net/juju-core/environs/simplestreams 0.256s
? launchpad.net/juju-core/environs/simplestreams/testing [no test files]
ok launchpad.net/juju-core/environs/sshstorage 0.744s
ok launchpad.net/juju-core/environs/sync 26.682s
ok launchpad.net/juju-core/environs/testing 0.011s
ok launchpad.net/juju-core/environs/tools 10.007s
? launchpad.net/juju-core/environs/tools/testing [no test files]
? launchpad.net/juju-core/errors [no test files]
ok launchpad.net/juju-core/instance 0.020s
ok launchpad.net/juju-core/juju 17.497s
ok launchpad.net/juju-core/juju/osenv 0.219s
? launchpad.net/juju-core/juju/testing [no test files]
ok launchpad.net/juju-core/log 0.015s
ok launchpad.net/juju-core/log/syslog 0.023s
ok launchpad.net/juju-core/names 0.037s
ok launchpad.net/juju-core/provider 0.259s
? launchpad.net/juju-core/provider/all [no test files]
ok launchpad.net/juju-core/provider/azure 6.380s
ok launchpad.net/juju-core/provider/dummy 20.464s
ok launchpad.net/juju-core/provider/ec2 5.396s
ok launchpad.net/juju-core/provider/ec2/httpstorage 0.049s
ok launchpad.net/juju-core/provider/local 1.800s
? launchpad.net/juju-core/provider/local/storage [no test files]
ok launchpad.net/juju-core/provider/maas 3.655s
ok launchpad.net/juju-core/provider/openstack 8.236s
ok launchpad.net/juju-core/rpc 0.264s
ok launchpad.net/juju-core/rpc/jsoncodec 0.270s
ok launchpad.net/juju-core/schema 0.018s

----------------------------------------------------------------------
PANIC: service_test.go:500: ServiceSuite.TestNewPeerRelationsAddedOnUpgrade

[LOG] 94.24505 INFO juju.state opening state; mongo addresses: ["localhost:48091"]; entity ""
[LOG] 94.26152 INFO juju.state connection established
[LOG] 94.29099 INFO juju.state initializing environment
... Panic: Couldn't create temporary directory: mkdir /tmp/gocheck-5074209722772702441: file exists (PC=0x414021)

/usr/lib/go/src/pkg/runtime/panic.c:229
  in panic
/home/tarmac/trees/src/launchpad.net/gocheck/gocheck.go:137
  in tempDir.newPath
/home/tarmac/trees/src/launchpad.net/gocheck/gocheck.go:159
  in C.MkDir
export_test.go:135
  in AddCustomCharm
conn_test.go:81
  in ConnSuite.AddMetaCharm
service_test.go:502
  in ServiceSuite.TestNewPeerRelationsAddedOnUpgrade
OOPS: 322 passed, 1 PANICKED
--- FAIL: TestPackage (69.21 seconds)
FAIL
FAIL launchpad.net/juju-core/state 69.408s
ok launchpad.net/juju-core/state/api 1.465s
ok launchpad.net/juju-core/state/api/agent 2.126s
? launchpad.net/juju-core/state/api/common [no test files]
ok launchpad.net/juju-core/state/api/deployer 5.823s
ok launchpad.net/juju-core/state/api/logger 2.248s
ok launchpad.net/juju-core/state/api/machiner 3.007s
ok launchpad.net/juju-core/state/api/params 0.031s
ok launchpad.net/juju-core/state/api/uniter 27.889s
ok launchpad.net/juju-core/state/api/upgrader 4.172s
ok launchpad.net/juju-core/state/api/watcher 3.741s
ok launchpad.net/juju-core/state/apiserver 4.550s
ok launchpad.net/juju-core/state/apiserver/agent 3.260s
ok launchpad.net/juju-core/state/apiserver/client 23.543s
ok launchpad.net/juju-core/state/apiserver/common 0.194s
ok launchpad.net/juju-core/state/apiserver/deployer 5.005s
ok launchpad.net/juju-core/state/apiserver/logger 3.897s
ok launchpad.net/juju-core/state/apiserver/machine 4.540s
? launchpad.net/juju-core/state/apiserver/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/uniter 18.153s
ok launchpad.net/juju-core/state/apiserver/upgrader 6.174s
ok launchpad.net/juju-core/state/multiwatcher 1.045s
ok launchpad.net/juju-core/state/presence 6.495s
ok launchpad.net/juju-core/state/statecmd 0.021s
? launchpad.net/juju-core/state/testing [no test files]
ok launchpad.net/juju-core/state/watcher 5.734s
ok launchpad.net/juju-core/store 19.370s
ok launchpad.net/juju-core/testing 1.382s
ok launchpad.net/juju-core/testing/checkers 0.018s
ok launchpad.net/juju-core/thirdparty/pbkdf2 0.135s
ok launchpad.net/juju-core/tools 0.019s
ok launchpad.net/juju-core/upstart 1.023s
ok launchpad.net/juju-core/utils 0.959s
ok launchpad.net/juju-core/utils/fslock 0.996s
ok launchpad.net/juju-core/utils/parallel 0.421s
ok launchpad.net/juju-core/utils/set 0.017s
ok launchpad.net/juju-core/version 0.065s
ok launchpad.net/juju-core/worker 1.715s
ok launchpad.net/juju-core/worker/cleaner 1.293s
ok launchpad.net/juju-core/worker/deployer 4.227s
ok launchpad.net/juju-core/worker/firewaller 12.613s
ok launchpad.net/juju-core/worker/logger 1.835s
ok launchpad.net/juju-core/worker/machiner 7.725s
ok launchpad.net/juju-core/worker/minunitsworker 1.372s
ok launchpad.net/juju-core/worker/provisioner 8.349s
ok launchpad.net/juju-core/worker/resumer 1.781s
ok launchpad.net/juju-core/worker/uniter 181.474s
ok launchpad.net/juju-core/worker/uniter/charm 3.663s
ok launchpad.net/juju-core/worker/uniter/debug 0.219s
ok launchpad.net/juju-core/worker/uniter/hook 0.037s
2013-09-18 06:43:06 INFO juju juju-log.go:66 u/0: msg

----------------------------------------------------------------------
PANIC: relation-get_test.go:233: RelationGetSuite.TestHelp

test 0
... Panic: Couldn't create temporary directory: mkdir /tmp/gocheck-5074209722772702441: file exists (PC=0x414121)

/usr/lib/go/src/pkg/runtime/panic.c:229
  in panic
/home/tarmac/trees/src/launchpad.net/gocheck/gocheck.go:137
  in tempDir.newPath
/home/tarmac/trees/src/launchpad.net/gocheck/gocheck.go:159
  in C.MkDir
/home/tarmac/trees/src/launchpad.net/juju-core/testing/cmd.go:39
  in Context
relation-get_test.go:239
  in RelationGetSuite.TestHelp
OOPS: 38 passed, 1 PANICKED
--- FAIL: TestPackage (0.32 seconds)
FAIL
FAIL launchpad.net/juju-core/worker/uniter/jujuc 0.975s
ok launchpad.net/juju-core/worker/uniter/relation 1.485s
ok launchpad.net/juju-core/worker/upgrader 3.358s

warning: building out-of-date packages:
 launchpad.net/goamz/ec2/ec2test
 launchpad.net/goamz/s3/s3test
 launchpad.net/goose/testservices/hook
 launchpad.net/goose/testservices/identityservice
 launchpad.net/goose/testservices
 launchpad.net/goose/testservices/novaservice
 launchpad.net/goose/testservices/swiftservice
 launchpad.net/goose/testservices/openstackservice
 launchpad.net/lpad
installing these packages with 'go test -i ./...' will speed future tests.