LGTM - although I'd prefer with the added testing helper method, this isn't essential.
https://codereview.appspot.com/13736043/diff/4001/environs/httpstorage/backend.go File environs/httpstorage/backend.go (right):
https://codereview.appspot.com/13736043/diff/4001/environs/httpstorage/backend.go#newcode54 environs/httpstorage/backend.go:54: defer readcloser.Close() On 2013/09/18 05:33:28, axw1 wrote: > On 2013/09/18 04:26:28, thumper wrote: > > Why defer? There is no harm in calling Close right now.
> Indeed. I'll keep the defer, but move it closer to Get/before ReadAll.
Good call. I missed the err just above.
https://codereview.appspot.com/13736043/
« Back to merge proposal
LGTM - although I'd prefer with the added testing helper method, this
isn't essential.
https:/ /codereview. appspot. com/13736043/ diff/4001/ environs/ httpstorage/ backend. go httpstorage/ backend. go (right):
File environs/
https:/ /codereview. appspot. com/13736043/ diff/4001/ environs/ httpstorage/ backend. go#newcode54 httpstorage/ backend. go:54: defer readcloser.Close()
environs/
On 2013/09/18 05:33:28, axw1 wrote:
> On 2013/09/18 04:26:28, thumper wrote:
> > Why defer? There is no harm in calling Close right now.
> Indeed. I'll keep the defer, but move it closer to Get/before ReadAll.
Good call. I missed the err just above.
https:/ /codereview. appspot. com/13736043/