Code review comment for lp:~axwalk/juju-core/localstorage-to-httpstorage

Revision history for this message
Andrew Wilkins (axwalk) wrote :

Reviewers: mp+185958_code.launchpad.net,

Message:
Please take a look.

Description:
environs/localstorage -> environs/httpstorage

localstorage becomes httpstorage; it no longer
operates on the disk, but instead delegates to
another environs.Storage object.

This work goes together with changes to
environs/filestorage, which will be modified to
write to temporary storage and atomically move,
in the same way that sshstorage has been coded.

https://code.launchpad.net/~axwalk/juju-core/localstorage-to-httpstorage/+merge/185958

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/13736043/

Affected files (+129, -133 lines):
   A [revision details]
   M cmd/jujud/machine.go
   M environs/bootstrap/bootstrap_test.go
   M environs/filestorage/filestorage.go
   M environs/httpstorage/backend.go
   M environs/httpstorage/backend_test.go
   M environs/httpstorage/storage.go
   M environs/httpstorage/storage_test.go
   M environs/testing/storage.go
   M provider/azure/environ_test.go
   M provider/local/environ.go
   M provider/local/storage/worker.go
   M provider/state_test.go

« Back to merge proposal