Merge lp:~axwalk/juju-core/juju-failed-bootstrap-destroy-jenv into lp:~go-bot/juju-core/trunk
Status: | Merged |
---|---|
Approved by: | Andrew Wilkins |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2310 |
Proposed branch: | lp:~axwalk/juju-core/juju-failed-bootstrap-destroy-jenv |
Merge into: | lp:~go-bot/juju-core/trunk |
Diff against target: |
213 lines (+69/-15) 6 files modified
cmd/juju/bootstrap.go (+18/-1) cmd/juju/bootstrap_test.go (+22/-0) cmd/juju/destroyenvironment_test.go (+4/-2) cmd/juju/synctools.go (+9/-1) environs/open.go (+7/-1) provider/dummy/environs.go (+9/-10) |
To merge this branch: | bzr merge lp:~axwalk/juju-core/juju-failed-bootstrap-destroy-jenv |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju Engineering | Pending | ||
Review via email: mp+204421@code.launchpad.net |
Commit message
cmd/juju: delete .jenv if bootstrap fails
If bootstrap fails, and the .jenv file did
not previously exist, then Juju will attempt
to destroy the environment in case of partial
creation. If this succeeds, the .jenv file
is destroyed. If it fails, an error message
is logged; we do not currently attempt to
forcefully remove the environment.
NOTE: if an environment is already prepared, say
by running sync-tools, then a failed bootstrap
will not attempt to destroy the environment.
Fixes lp:1247152
Description of the change
cmd/juju: delete .jenv if bootstrap fails
If bootstrap fails, and the .jenv file did
not previously exist, then Juju will attempt
to destroy the environment in case of partial
creation. If this succeeds, the .jenv file
is destroyed. If it fails, an error message
is logged; we do not currently attempt to
forcefully remove the environment.
NOTE: if an environment is already prepared, say
by running sync-tools, then a failed bootstrap
will not attempt to destroy the environment.
Fixes lp:1247152
Reviewers: mp+204421_ code.launchpad. net,
Message:
Please take a look.
Description:
cmd/juju: delete .jenv if bootstrap fails
If bootstrap fails, and the .jenv file did
not previously exist, then Juju will attempt
to destroy the environment in case of partial
creation. If this succeeds, the .jenv file
is destroyed. If environment destruction fails,
a warning message is displayed to the user
with directions to use destroy-environment with
a new --config-only flag.
juju destroy-environment now has a --config-only
flag that tells destroy-environment to only
destroy the configstore info for the named
environment. This is equivalent to deleting the
.jenv file, but allows for additional configstore
implementations in the future.
NOTE: if an environment is already prepared, say
by running sync-tools, then a failed bootstrap
will not attempt to destroy the environment.
Fixes lp:1247152
https:/ /code.launchpad .net/~axwalk/ juju-core/ juju-failed- bootstrap- destroy- jenv/+merge/ 204421
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/59560043/
Affected files (+106, -26 lines): juju/bootstrap. go juju/bootstrap_ test.go juju/destroyenv ironment. go juju/destroyenv ironment_ test.go dummy/environs. go
[revision details]
cmd/
cmd/
cmd/
cmd/
environs/open.go
provider/