It does seem that we are missing tests to ensure that each command is
wrapped as expected. We test the wrapping function itself in
environmentcommand but I can't see how or where we are testing that each
business command is wrapped eg for add-machine, how do we test that it
has been registered using
jujucmd.Register(wrap(&AddMachineCommand{}))and not just
jujucmd.Register(&AddMachineCommand{})
We should be able to iterate over all registered commands to check. Can
we do this before landing?
LGTM with perhaps a 2nd opinion from William.
It does seem that we are missing tests to ensure that each command is Register( wrap(&AddMachin eCommand{ }))and not just Register( &AddMachineComm and{})
wrapped as expected. We test the wrapping function itself in
environmentcommand but I can't see how or where we are testing that each
business command is wrapped eg for add-machine, how do we test that it
has been registered using
jujucmd.
jujucmd.
We should be able to iterate over all registered commands to check. Can
we do this before landing?
https:/ /codereview. appspot. com/94350045/