Code review comment for lp:~axwalk/juju-core/cmd-juju-unset-env

Revision history for this message
Andrew Wilkins (axwalk) wrote :

Reviewers: mp+212771_code.launchpad.net,

Message:
Please take a look.

Description:
Introduce unset-environment subcommand

A new juju subcommand, unset-environment (with unset-env alias)
is introduced. This subcommand will take the existing environment
config, remove the specified keys, and update it in state. If
the specified keys have associated defaults, then they will be
assigned.

This is necessary for removing configuration for which an empty
value is not permitted, e.g. for string attributes which are
omitted by default, such as http-proxy.

Fixes lp:1295372

https://code.launchpad.net/~axwalk/juju-core/cmd-juju-unset-env/+merge/212771

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/80380043/

Affected files (+196, -2 lines):
   A [revision details]
   M cmd/juju/environment.go
   M cmd/juju/environment_test.go
   M cmd/juju/main.go
   M cmd/juju/main_test.go
   M state/api/client.go
   M state/api/params/params.go
   M state/apiserver/client/client.go
   M state/apiserver/client/client_test.go

« Back to merge proposal