juju-core

Code review comment for lp:~axwalk/juju-core/client-cache-apihostports

  1. client-cache-apihostports
  2. Merge into trunk
Revision history for this message
Roger Peppe (rogpeppe) wrote :

still LGTM

https://codereview.appspot.com/81780043/diff/40001/state/api/apiclient.go
File state/api/apiclient.go (right):

https://codereview.appspot.com/81780043/diff/40001/state/api/apiclient.go#newcode215
state/api/apiclient.go:215: hostPorts[i] = append([]instance.HostPort{},
server...)
or hostPorts[i] = append(hostPorts[i], server...)
(slightly shorter)

https://codereview.appspot.com/81780043/

« Back to merge proposal