Code review comment for lp:~axwalk/juju-core/client-cache-apihostports

Revision history for this message
Andrew Wilkins (axwalk) wrote :

Reviewers: mp+213217_code.launchpad.net,

Message:
Please take a look.

Description:
Cache API server addresses in .jenv

We now return API server addresses from
the Login API, and cache those addresses
in the client's configstore. If the client
connects using environments.yaml, then it
is expected to get updated addresses from
provider-state.

https://code.launchpad.net/~axwalk/juju-core/client-cache-apihostports/+merge/213217

Requires:
https://code.launchpad.net/~axwalk/juju-core/apihostports-api/+merge/213200

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/81780043/

Affected files (+173, -11 lines):
   A [revision details]
   M juju/api.go
   M juju/apiconn_test.go
   M state/api/apiclient.go
   M state/api/params/params.go
   M state/api/state.go
   M state/apiserver/admin.go
   M state/apiserver/login_test.go

« Back to merge proposal