i got the note thanks. Will add a bug to the docs so I can add this to dev docs
On Tue, Apr 8, 2014 at 4:30 AM, Andrew Wilkins <email address hidden> wrote: > Please take a look. > > > https://codereview.appspot.com/84470052/diff/1/doc/azure-provider.txt > File doc/azure-provider.txt (right): > > https://codereview.appspot.com/84470052/diff/1/doc/azure-provider.txt#newcode101 > doc/azure-provider.txt:101: default, we set > availability-sets-enabled=true for new environments. > On 2014/04/07 09:10:22, fwereade wrote: >> I know you cover it later, but it would be good to have a single > sentence here, >> explicitly pointing out the tradeoff you're making by setting >> availability-sets-enabled to false. > > Done. > > https://codereview.appspot.com/84470052/ > > -- > https://code.launchpad.net/~axwalk/juju-core/azure-provider-doc/+merge/214478 > Your team juju hackers is requested to review the proposed merge of lp:~axwalk/juju-core/azure-provider-doc into lp:juju-core.
-- Nick Veitch <email address hidden>
« Back to merge proposal
i got the note thanks. Will add a bug to the docs so I can add this to dev docs
On Tue, Apr 8, 2014 at 4:30 AM, Andrew Wilkins /codereview. appspot. com/84470052/ diff/1/ doc/azure- provider. txt provider. txt (right): /codereview. appspot. com/84470052/ diff/1/ doc/azure- provider. txt#newcode101 provider. txt:101: default, we set sets-enabled= true for new environments. sets-enabled to false. /codereview. appspot. com/84470052/ /code.launchpad .net/~axwalk/ juju-core/ azure-provider- doc/+merge/ 214478
<email address hidden> wrote:
> Please take a look.
>
>
> https:/
> File doc/azure-
>
> https:/
> doc/azure-
> availability-
> On 2014/04/07 09:10:22, fwereade wrote:
>> I know you cover it later, but it would be good to have a single
> sentence here,
>> explicitly pointing out the tradeoff you're making by setting
>> availability-
>
> Done.
>
> https:/
>
> --
> https:/
> Your team juju hackers is requested to review the proposed merge of lp:~axwalk/juju-core/azure-provider-doc into lp:juju-core.
--
Nick Veitch
<email address hidden>