Code review comment for lp:~axwalk/juju-core/azure-mode-nounitplacement

Revision history for this message
Andrew Wilkins (axwalk) wrote :

Please take a look.

https://codereview.appspot.com/77950045/diff/1/provider/azure/environ.go
File provider/azure/environ.go (right):

https://codereview.appspot.com/77950045/diff/1/provider/azure/environ.go#newcode903
provider/azure/environ.go:903: return fmt.Errorf("unit placement is not
permitted with availability-sets-enabled")
On 2014/03/24 09:55:21, fwereade wrote:
> s/permitted/supported/

> ?

Done.

https://codereview.appspot.com/77950045/diff/1/provider/azure/environprovider.go
File provider/azure/environprovider.go (right):

https://codereview.appspot.com/77950045/diff/1/provider/azure/environprovider.go#newcode47
provider/azure/environprovider.go:47: // by default, unless the user set
a value.
On 2014/03/24 09:55:21, fwereade wrote:
> This behaviour definitely demands documentation -- please make sure
that (1) the
> release notes mention it and (2) you write something for the html
docs.

Filed https://bugs.launchpad.net/juju-core/+bug/1297066

https://codereview.appspot.com/77950045/

« Back to merge proposal