Code review comment for lp:~axwalk/juju-core/apiclient-open-parallel-fixes

Revision history for this message
Andrew Wilkins (axwalk) wrote :

Please take a look.

https://codereview.appspot.com/82900045/diff/1/state/api/apiclient.go
File state/api/apiclient.go (right):

https://codereview.appspot.com/82900045/diff/1/state/api/apiclient.go#newcode126
state/api/apiclient.go:126: } else if err != nil {
On 2014/04/01 07:42:07, rog wrote:
> s/else//

Done.

https://codereview.appspot.com/82900045/diff/1/state/api/apiclient.go#newcode199
state/api/apiclient.go:199: logger.Debugf("error dialing API server,
will retry: %v", err)
On 2014/04/01 07:42:07, rog wrote:
> perhaps include the cfg.Location here, otherwise when we've got a few
of these
> happening concurrently, we won't be able to tell which address is
giving which
> error.

Done.

https://codereview.appspot.com/82900045/

« Back to merge proposal