Code review comment for lp:~axwalk/juju-core/apiclient-open-parallel-fixes

Revision history for this message
Roger Peppe (rogpeppe) wrote :

LGTM, thanks

https://codereview.appspot.com/82900045/diff/1/state/api/apiclient.go
File state/api/apiclient.go (right):

https://codereview.appspot.com/82900045/diff/1/state/api/apiclient.go#newcode126
state/api/apiclient.go:126: } else if err != nil {
s/else//

https://codereview.appspot.com/82900045/diff/1/state/api/apiclient.go#newcode199
state/api/apiclient.go:199: logger.Debugf("error dialing API server,
will retry: %v", err)
perhaps include the cfg.Location here, otherwise when we've got a few of
these happening concurrently, we won't be able to tell which address is
giving which error.

https://codereview.appspot.com/82900045/

« Back to merge proposal