Code review comment for lp:~axwalk/juju-core/agent-watch-apihostports

Revision history for this message
Andrew Wilkins (axwalk) wrote :

Reviewers: mp+213778_code.launchpad.net,

Message:
Please take a look.

Description:
Introduce worker/apiaddressupdater

This proposal introduces a new worker that
watches changes to APIHostPorts, and then
updates agent config. The machine and unit
agents have both been updated to start this
worker.

https://code.launchpad.net/~axwalk/juju-core/agent-watch-apihostports/+merge/213778

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/83500043/

Affected files (+242, -0 lines):
   A [revision details]
   M cmd/jujud/agent.go
   M cmd/jujud/machine.go
   M cmd/jujud/machine_test.go
   M cmd/jujud/unit.go
   M cmd/jujud/unit_test.go
   A worker/apiaddressupdater/apiaddressupdater.go
   A worker/apiaddressupdater/apiaddressupdater_test.go

« Back to merge proposal