Code review comment for lp:~axwalk/juju-ci-tools/juju-ci-tools
Revision history for this message
| Nicholas Skaggs (nskaggs) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
For those watching this MP, the real bug here is this; juju register didn't work.
----------------
balloons: if you added a user with access to exactly one model, register would try to switch to it but failed to qualify its name
In addition, Andrew noted the test passed with Leo's new branch, making this branch not needed. We need to ensure the regression is still noted.
-------------
balloons: so to answer your question about why it wasn't failing: the test wasn't checking the exit status of the "juju register" pexpect process. register is failing right at the end, when it goes to set the current model. so the controller is set up, and further commands succeed because they're specifying a model with "-m"