Code review comment for lp:~axwalk/juju-ci-tools/juju-ci-tools
Revision history for this message
| Andrew Wilkins (axwalk) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
> Thanks for doing this Andrew. Poked Nicholas to have a look yesterday, but
> he's in sprint-mode I guess. He was sure that there was another issue as well
> beyond just the model naming, but I didn't get the details out of him.
>
> The basic change here seems right, but seems like this really needs to be in
> jujupy. That can probably happen in a later branch. Does the change work on
> master at present? I expect it should.
Urgh, actually no it won't. Can we break CI temporarily, while the juju PR is pending? I'm not sure how easy it'll be to detect/keep compat. It's just for a beta as well...