goamz

Code review comment for lp:~axwalk/goamz/ec2test-empty-dnsname

  1. ec2test-empty-dnsname
  2. Merge into trunk
Revision history for this message
Roger Peppe (rogpeppe) wrote :

LGTM with one thought below.

https://codereview.appspot.com/43650045/diff/1/ec2/ec2test/server.go
File ec2/ec2test/server.go (right):

https://codereview.appspot.com/43650045/diff/1/ec2/ec2test/server.go#newcode567
ec2/ec2test/server.go:567: PrivateDNSName:
fmt.Sprintf("%s.internal.invalid", id),
I wonder if we should do it for these addresses too.

https://codereview.appspot.com/43650045/

« Back to merge proposal