Code review comment for lp:~axwalk/charms/trusty/ceph/trunk

Revision history for this message
James Page (james-page) wrote :

I've merged the update to charm-helpers - please sync away!

On Mon, Nov 23, 2015 at 1:56 AM, Andrew Wilkins <
<email address hidden>> wrote:

> I've fixed the proof error (proof is stricter than necessary, but follows
> the docs), and added an optional osd-journal store. This is currently
> handled the same as the existing config: one-shot, at deployment time only.
> Storage charmers will need to update it to handle dynamic journal changes
> if that's ever a requirement.
>
> I've put up another MP to charm-helpers to fix the optional parameters
> inconsistency, and will update this when it's merged.
> --
> https://code.launchpad.net/~axwalk/charms/trusty/ceph/trunk/+merge/276727
> You are reviewing the proposed merge of
> lp:~axwalk/charms/trusty/ceph/trunk into
> lp:~openstack-charmers/charms/trusty/ceph/next.
>

« Back to merge proposal